android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: falcon: Add of_node_put() before return

Browse Source 
Each iteration of for_each_compatible_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in two
places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804152745.2231-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Nishka Dasgupta
2019-08-04 20:57:45 +05:30
committed by Linus Walleij
parent d55b7fdd58
commit f17d2f54d3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pinctrl/pinctrl-falcon.c
View File

@ -451,12 +451,15 @@ static int pinctrl_falcon_probe(struct platform_device *pdev)
falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL); falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
if (IS_ERR(falcon_info.clk[*bank])) { if (IS_ERR(falcon_info.clk[*bank])) {
dev_err(&ppdev->dev, "failed to get clock\n"); dev_err(&ppdev->dev, "failed to get clock\n");
of_node_put(np)
return PTR_ERR(falcon_info.clk[*bank]); return PTR_ERR(falcon_info.clk[*bank]);
} }
falcon_info.membase[*bank] = devm_ioremap_resource(&pdev->dev, falcon_info.membase[*bank] = devm_ioremap_resource(&pdev->dev,
&res); &res);
if (IS_ERR(falcon_info.membase[*bank])) if (IS_ERR(falcon_info.membase[*bank])) {
of_node_put(np);
return PTR_ERR(falcon_info.membase[*bank]); return PTR_ERR(falcon_info.membase[*bank]);
}
avail = pad_r32(falcon_info.membase[*bank], avail = pad_r32(falcon_info.membase[*bank],
LTQ_PADC_AVAIL); LTQ_PADC_AVAIL);