android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

9p: do not crash on unknown lock status code

Browse Source 
Current 9p implementation will crash whole system if sees unknown lock
status code. It's trivial target for DOS: 9p server can produce such
code easily.

Let's fallback more gracefully: warning in dmesg + -ENOLCK.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
This commit is contained in:
Kirill A. Shutemov 2014-12-29 15:00:19 +02:00 committed by Eric Van Hensbergen
parent ad80492df5
commit b642f7269b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/9p/vfs_file.c
View File

@ -212,12 +212,13 @@ static int v9fs_file_do_lock(struct file *filp, int cmd, struct file_lock *fl)
case P9_LOCK_BLOCKED: case P9_LOCK_BLOCKED:
res = -EAGAIN; res = -EAGAIN;
break; break;
default:
WARN_ONCE(1, "unknown lock status code: %d\n", status);
/* fallthough */
case P9_LOCK_ERROR: case P9_LOCK_ERROR:
case P9_LOCK_GRACE: case P9_LOCK_GRACE:
res = -ENOLCK; res = -ENOLCK;
break; break;
default:
BUG();
} }
out_unlock: out_unlock: