android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: qcom: Don't lock around irq_set_irq_wake()

Browse Source 
We don't need to hold the local pinctrl lock here to set irq wake on the
summary irq line. Doing so only leads to lockdep warnings instead of
protecting us from anything. Remove the locking.

Change-Id: I89a9bca1ed4c8aab8b9ecd2000a116c74e33b186
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Git-commit: 1d44616e7549d0154c1224a3eee3c407029294dc
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: Manoj Vishwanathan <mvishwan@codeaurora.org>
This commit is contained in:
Stephen Boyd 2021-01-26 16:50:38 -08:00 committed by Gerrit - the friendly Code Review server
parent c5e6208da8
commit 98b2216218
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pinctrl/qcom/pinctrl-msm.c
View File

@ -1199,7 +1199,6 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
struct msm_pinctrl *pctrl = gpiochip_get_data(gc);
unsigned long flags;
if (d->parent_data)
irq_chip_set_wake_parent(d, on);
@ -1210,12 +1209,8 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
* when TLMM is powered on. To allow that, enable the GPIO
* summary line to be wakeup capable at GIC.
*/
raw_spin_lock_irqsave(&pctrl->lock, flags);
irq_set_irq_wake(pctrl->irq, on);
raw_spin_unlock_irqrestore(&pctrl->lock, flags);
return 0;
}