android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ANDROID: Incremental fs: Remove all access_ok checks

Browse Source 
They provide no value and simply duplicate a check in copy_from/to_user

Test: incfs_test passes
Bug: 138149732
Signed-off-by: Paul Lawrence <paullawrence@google.com>
Change-Id: Icc6054a2d6a495c9a03cd1507dda1ab8ca0b0dc4
This commit is contained in:
Paul Lawrence 2020-03-16 13:47:17 -07:00
parent 0d094683fc
commit 8dfd3a1e24
1 changed files with 2 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
fs/incfs/vfs.c
View File

@ -463,9 +463,6 @@ static ssize_t pending_reads_read(struct file *f, char __user *buf, size_t len,
ssize_t result = 0;
int i = 0;
if (!access_ok(buf, len))
return -EFAULT;
if (!incfs_fresh_pending_reads_exist(mi, last_known_read_sn))
return 0;
@ -857,9 +854,6 @@ static struct signature_info *incfs_copy_signature_info_from_user(
if (!original)
return NULL;
if (!access_ok(original, sizeof(usr_si)))
return ERR_PTR(-EFAULT);
if (copy_from_user(&usr_si, original, sizeof(usr_si)) > 0)
return ERR_PTR(-EFAULT);
@ -1189,10 +1183,7 @@ static long ioctl_create_file(struct mount_info *mi,
error = -EFAULT;
goto out;
}
if (!access_ok(usr_args, sizeof(args))) {
error = -EFAULT;
goto out;
}
if (copy_from_user(&args, usr_args, sizeof(args)) > 0) {
error = -EFAULT;
goto out;
@ -1318,12 +1309,6 @@ static long ioctl_create_file(struct mount_info *mi,
goto delete_index_file;
}
if (!access_ok(u64_to_user_ptr(args.file_attr),
args.file_attr_len)) {
error = -EFAULT;
goto delete_index_file;
}
if (copy_from_user(attr_value,
u64_to_user_ptr(args.file_attr),
args.file_attr_len) > 0) {
@ -1385,15 +1370,9 @@ static long ioctl_read_file_signature(struct file *f, void __user *arg)
if (!df)
return -EINVAL;
if (!access_ok(args_usr_ptr, sizeof(args)))
return -EFAULT;
if (copy_from_user(&args, args_usr_ptr, sizeof(args)) > 0)
return -EINVAL;
if (!access_ok(u64_to_user_ptr(args.file_signature),
args.file_signature_buf_size))
return -EFAULT;
sig_buf_size = args.file_signature_buf_size;
if (sig_buf_size > INCFS_MAX_SIGNATURE_SIZE)
return -E2BIG;
@ -1915,9 +1894,6 @@ static ssize_t file_write(struct file *f, const char __user *buf,
if (!df)
return -EBADF;
if (!access_ok(usr_blocks, size))
return -EFAULT;
data_buf = (u8 *)__get_free_pages(GFP_NOFS, get_order(data_buf_size));
if (!data_buf)
return -ENOMEM;
@ -1934,11 +1910,7 @@ static ssize_t file_write(struct file *f, const char __user *buf,
error = -E2BIG;
break;
}
if (!access_ok(u64_to_user_ptr(block.data),
block.data_len)) {
error = -EFAULT;
break;
}
if (copy_from_user(data_buf, u64_to_user_ptr(block.data),
block.data_len) > 0) {
error = -EFAULT;