android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netfilter: nf_tables: remove unused variable in nf_tables_dump_set()

Browse Source 
The nfmsg variable is not used (except in sizeof operator which does
not care about its value) between the first and second time it is
assigned the value.  Furthermore, nlmsg_data has no side effects, so
the assignment can be safely removed.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Cc: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Michal Nazarewicz 2014-01-01 06:27:19 +01:00 committed by Pablo Neira Ayuso
parent 1466291790
commit 720e0dfa3a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/netfilter/nf_tables_api.c
View File

@ -2505,9 +2505,8 @@ static int nf_tables_dump_set(struct sk_buff *skb, struct netlink_callback *cb)
u32 portid, seq; u32 portid, seq;
int event, err; int event, err;
nfmsg = nlmsg_data(cb->nlh); err = nlmsg_parse(cb->nlh, sizeof(struct nfgenmsg), nla,
err = nlmsg_parse(cb->nlh, sizeof(*nfmsg), nla, NFTA_SET_ELEM_LIST_MAX, NFTA_SET_ELEM_LIST_MAX, nft_set_elem_list_policy);
nft_set_elem_list_policy);
if (err < 0) if (err < 0)
return err; return err;