android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ALSA] pcm - Fix zero-division in 32bit compat layer

Browse Source 
PCM Midlevel
Fixed zero-division bug in PCM 32bit compat layer.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2005-08-25 19:51:47 +02:00 committed by Jaroslav Kysela
parent e0c93cf311
commit 7153a558ad
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sound/core/pcm_compat.c
View File

@ -144,7 +144,7 @@ static int snd_pcm_ioctl_sw_params_compat(snd_pcm_substream_t *substream,
err = snd_pcm_sw_params(substream, &params); err = snd_pcm_sw_params(substream, &params);
if (err < 0) if (err < 0)
return err; return err;
if (put_user(boundary, &src->boundary)) if (boundary && put_user(boundary, &src->boundary))
return -EFAULT; return -EFAULT;
return err; return err;
} }
@ -252,8 +252,11 @@ static int snd_pcm_ioctl_hw_params_compat(snd_pcm_substream_t *substream,
goto error; goto error;
} }
if (! refine) if (! refine) {
runtime->boundary = recalculate_boundary(runtime); unsigned int new_boundary = recalculate_boundary(runtime);
if (new_boundary)
runtime->boundary = new_boundary;
}
error: error:
kfree(data); kfree(data);
return err; return err;
@ -408,6 +411,8 @@ static int snd_pcm_ioctl_sync_ptr_compat(snd_pcm_substream_t *substream,
status = runtime->status; status = runtime->status;
control = runtime->control; control = runtime->control;
boundary = recalculate_boundary(runtime); boundary = recalculate_boundary(runtime);
if (! boundary)
boundary = 0x7fffffff;
snd_pcm_stream_lock_irq(substream); snd_pcm_stream_lock_irq(substream);
/* FIXME: we should consider the boundary for the sync from app */ /* FIXME: we should consider the boundary for the sync from app */
if (!(sflags & SNDRV_PCM_SYNC_PTR_APPL)) if (!(sflags & SNDRV_PCM_SYNC_PTR_APPL))