android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm: slub: reinitialize random sequence cache on slab object update

Browse Source 
Random sequence cache is precomputed during slab object creation
based up on the object size and no of objects per slab. These could
be changed when flags like SLAB_STORE_USER, SLAB_POISON are updated
from sysfs. So when shuffle_freelist is called during slab_alloc it
uses updated object count to access the precomputed random sequence
cache. This could result in incorrect access of the random sequence
cache which could further result in slab corruption. Fix this by
reinitializing the random sequence cache up on slab object update.

A sample panic trace when write to slab_store_user was attempted.

Call trace0:
 exception
 set_freepointer(inline)
 shuffle_freelist(inline)
 new_slab+0x688/0x690
 ___slab_alloc+0x548/0x6f8
 kmem_cache_alloc+0x3dc/0x418
 zs_malloc+0x60/0x578
 zram_bvec_rw+0x66c/0xaa0
 zram_make_request+0x190/0x2c8
 generic_make_request+0x1f8/0x420
 submit_bio+0x140/0x1d8
 submit_bh_wbc+0x1a0/0x1e0
 __block_write_full_page+0x3a0/0x5e8
 block_write_full_page+0xec/0x108
 blkdev_writepage+0x2c/0x38
 __writepage+0x34/0x98
 write_cache_pages+0x33c/0x598
 generic_writepages+0x54/0x98
 blkdev_writepages+0x24/0x30
 do_writepages+0x90/0x138
 __filemap_fdatawrite_range+0xc0/0x128
 file_write_and_wait_range+0x44/0xa0
 blkdev_fsync+0x38/0x68
 __arm64_sys_fsync+0x6c/0xb8.

Change-Id: Ia87ff808d23ff8dbb721d3cc3e3b29771200ec5a
Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
This commit is contained in:
Vijayanand Jitta 2020-01-30 11:16:10 +05:30 committed by Gerrit - the friendly Code Review server
parent b38b5109bf
commit 6b4e340af6
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
mm/slub.c
View File

@ -1541,6 +1541,25 @@ static int init_cache_random_seq(struct kmem_cache *s)
return 0; return 0;
} }
/* re-initialize the random sequence cache */
static int reinit_cache_random_seq(struct kmem_cache *s)
{
int err;
if (s->random_seq) {
cache_random_seq_destroy(s);
err = init_cache_random_seq(s);
if (err) {
pr_err("SLUB: Unable to re-initialize random sequence cache for %s\n",
s->name);
return err;
}
}
return 0;
}
/* Initialize each random sequence freelist per cache */ /* Initialize each random sequence freelist per cache */
static void __init init_freelist_randomization(void) static void __init init_freelist_randomization(void)
{ {
@ -1615,6 +1634,10 @@ static inline int init_cache_random_seq(struct kmem_cache *s)
{ {
return 0; return 0;
} }
static inline int reinit_cache_random_seq(struct kmem_cache *s)
{
return 0;
}
static inline void init_freelist_randomization(void) { } static inline void init_freelist_randomization(void) { }
static inline bool shuffle_freelist(struct kmem_cache *s, struct page *page) static inline bool shuffle_freelist(struct kmem_cache *s, struct page *page)
{ {
@ -4968,6 +4991,7 @@ static ssize_t order_store(struct kmem_cache *s,
return -EINVAL; return -EINVAL;
calculate_sizes(s, order); calculate_sizes(s, order);
reinit_cache_random_seq(s);
return length; return length;
} }
@ -5205,6 +5229,7 @@ static ssize_t red_zone_store(struct kmem_cache *s,
s->flags |= SLAB_RED_ZONE; s->flags |= SLAB_RED_ZONE;
} }
calculate_sizes(s, -1); calculate_sizes(s, -1);
reinit_cache_random_seq(s);
return length; return length;
} }
SLAB_ATTR(red_zone); SLAB_ATTR(red_zone);
@ -5225,6 +5250,7 @@ static ssize_t poison_store(struct kmem_cache *s,
s->flags |= SLAB_POISON; s->flags |= SLAB_POISON;
} }
calculate_sizes(s, -1); calculate_sizes(s, -1);
reinit_cache_random_seq(s);
return length; return length;
} }
SLAB_ATTR(poison); SLAB_ATTR(poison);
@ -5246,6 +5272,7 @@ static ssize_t store_user_store(struct kmem_cache *s,
s->flags |= SLAB_STORE_USER; s->flags |= SLAB_STORE_USER;
} }
calculate_sizes(s, -1); calculate_sizes(s, -1);
reinit_cache_random_seq(s);
return length; return length;
} }
SLAB_ATTR(store_user); SLAB_ATTR(store_user);