android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

9p: Fix possible inode leak in v9fs_get_inode.

Browse Source 
Add a missing iput when cleaning up if v9fs_get_inode
fails after returning a valid inode.

Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
This commit is contained in:
Abhishek Kulkarni 2009-07-19 13:41:56 -06:00 committed by Eric Van Hensbergen
parent 50fb6d2bd7
commit 2bb541157f
1 changed files with 57 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
fs/9p/vfs_inode.c
View File

@ -207,13 +207,18 @@ v9fs_blank_wstat(struct p9_wstat *wstat)
struct inode *v9fs_get_inode(struct super_block *sb, int mode) struct inode *v9fs_get_inode(struct super_block *sb, int mode)
{ {
int err;
struct inode *inode; struct inode *inode;
struct v9fs_session_info *v9ses = sb->s_fs_info; struct v9fs_session_info *v9ses = sb->s_fs_info;
P9_DPRINTK(P9_DEBUG_VFS, "super block: %p mode: %o\n", sb, mode); P9_DPRINTK(P9_DEBUG_VFS, "super block: %p mode: %o\n", sb, mode);
inode = new_inode(sb); inode = new_inode(sb);
if (inode) { if (!inode) {
P9_EPRINTK(KERN_WARNING, "Problem allocating inode\n");
return -ENOMEM;
}
inode->i_mode = mode; inode->i_mode = mode;
inode->i_uid = current_fsuid(); inode->i_uid = current_fsuid();
inode->i_gid = current_fsgid(); inode->i_gid = current_fsgid();
@ -230,10 +235,10 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode)
if (!v9fs_extended(v9ses)) { if (!v9fs_extended(v9ses)) {
P9_DPRINTK(P9_DEBUG_ERROR, P9_DPRINTK(P9_DEBUG_ERROR,
"special files without extended mode\n"); "special files without extended mode\n");
return ERR_PTR(-EINVAL); err = -EINVAL;
goto error;
} }
init_special_inode(inode, inode->i_mode, init_special_inode(inode, inode->i_mode, inode->i_rdev);
inode->i_rdev);
break; break;
case S_IFREG: case S_IFREG:
inode->i_op = &v9fs_file_inode_operations; inode->i_op = &v9fs_file_inode_operations;
@ -243,7 +248,8 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode)
if (!v9fs_extended(v9ses)) { if (!v9fs_extended(v9ses)) {
P9_DPRINTK(P9_DEBUG_ERROR, P9_DPRINTK(P9_DEBUG_ERROR,
"extended modes used w/o 9P2000.u\n"); "extended modes used w/o 9P2000.u\n");
return ERR_PTR(-EINVAL); err = -EINVAL;
goto error;
} }
inode->i_op = &v9fs_symlink_inode_operations; inode->i_op = &v9fs_symlink_inode_operations;
break; break;
@ -256,16 +262,17 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode)
inode->i_fop = &v9fs_dir_operations; inode->i_fop = &v9fs_dir_operations;
break; break;
default: default:
P9_DPRINTK(P9_DEBUG_ERROR, P9_DPRINTK(P9_DEBUG_ERROR, "BAD mode 0x%x S_IFMT 0x%x\n",
"BAD mode 0x%x S_IFMT 0x%x\n",
mode, mode & S_IFMT); mode, mode & S_IFMT);
return ERR_PTR(-EINVAL); err = -EINVAL;
} goto error;
} else {
P9_EPRINTK(KERN_WARNING, "Problem allocating inode\n");
return ERR_PTR(-ENOMEM);
} }
return inode; return inode;
error:
iput(inode);
return ERR_PTR(err);
} }
/* /*