android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mbcs: cdev lock_kernel() pushdown

Browse Source 
This driver would appear to have no internal locking at all.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Jonathan Corbet 2008-05-15 11:24:23 -06:00
parent 2d863e92ec
commit 12ead6b098
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/mbcs.c
View File

@ -24,6 +24,7 @@
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/uio.h> #include <linux/uio.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/smp_lock.h>
#include <asm/io.h> #include <asm/io.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <asm/system.h> #include <asm/system.h>
@ -382,15 +383,19 @@ static int mbcs_open(struct inode *ip, struct file *fp)
struct mbcs_soft *soft; struct mbcs_soft *soft;
int minor; int minor;
lock_kernel();
minor = iminor(ip); minor = iminor(ip);
/* Nothing protects access to this list... */
list_for_each_entry(soft, &soft_list, list) { list_for_each_entry(soft, &soft_list, list) {
if (soft->nasid == minor) { if (soft->nasid == minor) {
fp->private_data = soft->cxdev; fp->private_data = soft->cxdev;
unlock_kernel();
return 0; return 0;
} }
} }
unlock_kernel();
return -ENODEV; return -ENODEV;
} }