From 09de85d415c6ff6198411793e893e08340132fcc Mon Sep 17 00:00:00 2001 From: Lingutla Chandrasekhar Date: Fri, 1 Mar 2019 17:17:09 +0530 Subject: [PATCH] trace: Add trace points for tasklet entry/exit Tasklets are supposed to finish their work quickly and should not block the current running process, but it is not guaranteed that. Currently softirq_entry/exit can be used to know total tasklets execution time, but not helpful to track individual tasklet's execution time. With that we can't find any culprit tasklet function, which is taking more time. Add tasklet_entry/exit trace point support to track individual tasklet execution. Change-Id: I3496d15f64d020916774e673ccb4a8116ea2f2c9 Signed-off-by: Lingutla Chandrasekhar [satyap@codeaurora.org: remove hi trace points and update commit text] Signed-off-by: Satya Durga Srinivasu Prabhala --- include/trace/events/irq.h | 31 +++++++++++++++++++++++++++++++ kernel/softirq.c | 2 ++ 2 files changed, 33 insertions(+) diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h index eeceafaaea4c..c12f40463f4c 100644 --- a/include/trace/events/irq.h +++ b/include/trace/events/irq.h @@ -160,6 +160,37 @@ DEFINE_EVENT(softirq, softirq_raise, TP_ARGS(vec_nr) ); +DECLARE_EVENT_CLASS(tasklet, + + TP_PROTO(void *func), + + TP_ARGS(func), + + TP_STRUCT__entry( + __field( void *, func) + ), + + TP_fast_assign( + __entry->func = func; + ), + + TP_printk("function=%ps", __entry->func) +); + +DEFINE_EVENT(tasklet, tasklet_entry, + + TP_PROTO(void *func), + + TP_ARGS(func) +); + +DEFINE_EVENT(tasklet, tasklet_exit, + + TP_PROTO(void *func), + + TP_ARGS(func) +); + #endif /* _TRACE_IRQ_H */ /* This part must be outside protection */ diff --git a/kernel/softirq.c b/kernel/softirq.c index 13edfcbb71c8..0ee55ec4f7a0 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -523,7 +523,9 @@ static void tasklet_action_common(struct softirq_action *a, if (!test_and_clear_bit(TASKLET_STATE_SCHED, &t->state)) BUG(); + trace_tasklet_entry(t->func); t->func(t->data); + trace_tasklet_exit(t->func); tasklet_unlock(t); continue; }